Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Helper function isTimeString to Python #471

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Added Helper function isTimeString to Python #471

merged 1 commit into from
Jul 21, 2022
+54 −1

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jul 21, 2022

Signed-off-by: ahcorde [email protected]

🎉 New feature

Summary

Added Helper function isTimeString to Python

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde self-assigned this Jul 21, 2022
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Jul 21, 2022
@codecov
Copy link

codecov bot commented Jul 21, 2022 •
edited
Loading

Codecov Report

Merging #471 (1f64dd4) into ign-math6 (88ee511) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           ign-math6     #471   +/-   ##
==========================================
  Coverage      99.68%   99.68%           
==========================================
  Files             73       73           
  Lines           6901     6901           
==========================================
  Hits            6879     6879           
  Misses            22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88ee511...1f64dd4. Read the comment docs.

@chapulina chapulina added the scripting Scripting interfaces to Ignition label Jul 21, 2022
@chapulina chapulina merged commit 577fc02 into ign-math6 Jul 21, 2022
@chapulina chapulina deleted the ahcorde/python/is_time_string branch July 21, 2022 22:43
@ahcorde ahcorde mentioned this pull request Aug 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityapande-1995 adityapande-1995 adityapande-1995 approved these changes

@chapulina chapulina chapulina approved these changes

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees

@ahcorde ahcorde

Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11 scripting Scripting interfaces to Ignition
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @chapulina @adityapande-1995